ci: ignore handled deprecation notice from phpstan #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
force-pushed
the
fix/noid/phpstan-ignore-deprecation
branch
3 times, most recently
from
0409621 to
ff39d20
Compare
The code already uses the new methods if available, the deprecated method is used only on older yet still supported Nextcloud versions. Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/noid/phpstan-ignore-deprecation
branch
from
ff39d20 to
f79f641
Compare
Grotax
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code already uses the new methods if available, the deprecated method is used only on older yet still supported Nextcloud versions.
For phpstan would complain when an ignored error would not appear, the additional config flag is necessary.
This turns the phpstan test green again.