fix(dev): Use a buildx builder instance we control instead of the default #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault
We require the "docker-container" driver (via options we pass to `docker
buildx build`, e.g. --cache-to) but the default builder instance may use
the "docker" driver, leading to errors on dev machines like:
ERROR: cache export feature is currently not supported for docker
driver. Please switch to a different driver (eg. "docker buildx
create --use")
Being explicit about our builder avoids that.
This same pattern is used in nextstrain/docker-base's devel/build.¹
¹ <nextstrain/docker-base@fac834e5>
<https://github.com/nextstrain/docker-base/blob/0acdc799/devel/build#L48-L56>
Related-to: <#1529 (comment)>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require the "docker-container" driver (via options we pass to
docker buildx build, e.g. --cache-to) but the default builder instance may use the "docker" driver, leading to errors on dev machines like:Being explicit about our builder avoids that.
This same pattern is used in nextstrain/docker-base's devel/build.¹
¹ nextstrain/docker-base@fac834e5
https://github.com/nextstrain/docker-base/blob/0acdc799/devel/build#L48-L56
Related-to: #1529 (comment)