-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(web): performance tweaks #972
Draft
ivan-aksamentov
wants to merge
6
commits into
master
Choose a base branch
from
perf/enable-ssr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
52ed142
perf: lazy load, reduce size of portrait images
ivan-aksamentov 1233150
perf: don't show changelog by default to reduce initial markup size
ivan-aksamentov a79330a
perf: enable prerendering of main page
ivan-aksamentov a3ac1b6
perf: split results page bundle away from main page bundle
ivan-aksamentov be5e395
perf: split modal dialogs code away from main bundle
ivan-aksamentov fbaa646
perf: reduce dom depth by coverting inline svgs into img tags
ivan-aksamentov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
packages_rs/nextclade-web/src/components/Citation/CitationDialog.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| import React from 'react' | ||
| import { | ||
| Button, | ||
| ButtonProps, | ||
| Col, | ||
| Container, | ||
| Modal as ReactstrapModal, | ||
| ModalBody as ReactstrapModalBody, | ||
| ModalFooter as ReactstrapModalFooter, | ||
| ModalHeader as ReactstrapModalHeader, | ||
| Row, | ||
| } from 'reactstrap' | ||
| import { Citation } from 'src/components/Citation/Citation' | ||
| import { useTranslationSafe } from 'src/helpers/useTranslationSafe' | ||
| import styled from 'styled-components' | ||
|
|
||
| export const ButtonOk = styled(Button)<ButtonProps>` | ||
| width: 100px; | ||
| ` | ||
| export const ModalHeader = styled(ReactstrapModalHeader)` | ||
| .modal-title { | ||
| width: 100%; | ||
| } | ||
|
|
||
| @media (max-width: 992px) { | ||
| padding: 0.25rem; | ||
| margin: 0.5rem; | ||
| margin-bottom: 0; | ||
| } | ||
| ` | ||
| export const Modal = styled(ReactstrapModal)` | ||
| height: 100%; | ||
|
|
||
| // fullscreen on mobile | ||
| @media (max-width: 992px) { | ||
| max-width: unset; | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| right: 0; | ||
| bottom: 0; | ||
| margin: 0; | ||
| padding: 0; | ||
|
|
||
| .modal-content { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| right: 0; | ||
| bottom: 0; | ||
| margin: 0; | ||
| } | ||
| } | ||
| ` | ||
| export const ModalBody = styled(ReactstrapModalBody)` | ||
| @media (min-width: 991.98px) { | ||
| max-height: 66vh; | ||
| margin: auto; | ||
| } | ||
|
|
||
| @media (max-width: 992px) { | ||
| margin: 1rem 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| overflow-y: auto; | ||
| ` | ||
| export const ModalFooter = styled(ReactstrapModalFooter)` | ||
| margin: 0; | ||
| padding: 0; | ||
| ` | ||
|
|
||
| export interface CitationDialogProps { | ||
| isOpen: boolean | ||
| toggle: () => void | ||
| } | ||
|
|
||
| export default function CitationDialog({ isOpen, toggle }: CitationDialogProps) { | ||
| const { t } = useTranslationSafe() | ||
| const text = t('Citation') | ||
| const closeText = t('Close this window') | ||
|
|
||
| return ( | ||
| <Modal centered isOpen={isOpen} toggle={toggle} fade={false} size="lg"> | ||
| <ModalHeader toggle={toggle} tag="div"> | ||
| <h2 className="text-center">{text}</h2> | ||
| </ModalHeader> | ||
|
|
||
| <ModalBody> | ||
| <Citation /> | ||
| </ModalBody> | ||
|
|
||
| <ModalFooter> | ||
| <Container fluid> | ||
| <Row noGutters className="my-2"> | ||
| <Col className="d-flex w-100"> | ||
| <ButtonOk className="ml-auto" type="button" color="success" onClick={toggle} title={closeText}> | ||
| {t('Ok')} | ||
| </ButtonOk> | ||
| </Col> | ||
| </Row> | ||
| </Container> | ||
| </ModalFooter> | ||
| </Modal> | ||
| ) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totggleis a typo oftoggleI think :)