-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCC 14.1.0. #675
Add GCC 14.1.0. #675
Conversation
Instead of "serialize" the arguments , this commit uses by-reference argument passing (Bash 5.3+). We now can pass array as-is so we later can enumerate them, select C|CXX|LDFLAGS from them, and made them as environment variable. As as result, now we can correctly run the configure scripts who doesn't support list FOO=bar as argument (like termcap).
You might want to update
Is it possible to actually fix code rather than silencing warnings? |
Fixed, thanks!
Sure we can make many patches instead of silence warnings. But analyzing these errors is, somehow, quite difficult. For example in On the other hand, If we add (unnecessary) patches today, we will have more work to do in the future: maintaining these patches once the upstream has update. That's not what I expected, at least -- I just want a stable build script, that means updating packages should be an easy work. At least, one may think these "-Wno-error" introduce some "bad smell"... probably yes, but actually it does not change anything from previous version since it just makes implicit options explicit. |
Fair enough. |
Atrifact is from GitHub Actions, which comes from a PR. It is not product build so no release https://github.com/niXman/mingw-builds/actions/runs/9028969794 niXman/mingw-builds#675
Sorry for a so big PR, but it might be necessary to change these files.
Here is what it does:
gcc-14.1.0
andgcc-14-branch
;expat
version (this suppresses Update expat to 2.6.2 #671 and fixes Update expat to 2.6.2 #672), because v2.5.0 no longer available to download due to vulnerability;gdb
to 14.2. (Original version failed under GCC 14)termcap
andpython-3
needsCFLAGS
like-fpermissive
or-Wno-error=implicit-function-declaration
now.python-3
, an additional patch applied.termcap
, an additional patch applied (wtf the original Makefile do not useCFLAGS
); AND ALSO, change the way to passCFLAGS
etc. to theconfigure
script.configure
script doesn't recognizeFOO=bar
in command line arguments as environment variable (that's why in previous version, those CFLAGS settings are commented out).PKG_CONFIGURE_FLAGS
infunc_configure
, so thatCFLAGS
etc. are exported as environment variables instead of passing them as command line arguments.PKG_CONFIGURE_FLAGS
array structure as-is, now I'm using-n
flag (a.k.a. pass array argument by reference) that supports from Bash 5.3 (ref, and ref). As a benefit, we can now remove all extra "escaped quotation mark" in*FLAGS
settings.I've tested these changes and successfully built GCC 14.1.0 with SEH, Win32, UCRT and v11 runtime. Let's wait for GitHub Actions' result.