Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mesh gateway example #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eeeschwartz
Copy link

(rehash of PR #7) This incorporates the central configs so that it works out of the box:

$ cd gateways
$ docker-compose up
$ curl localhost:9090
{
  "name": "web",
  "uri": "/",
  "type": "HTTP",
  "start_time": "2019-12-24T19:50:49.746164",
  "end_time": "2019-12-24T19:50:49.790219",
  "duration": "44.0532ms",
  "body": "Hello World",
  "upstream_calls": [
    {
      "name": "payments-v2",
      "uri": "http://localhost:9091",
      "type": "HTTP",
      "start_time": "2019-12-24T19:50:49.762915",
      "end_time": "2019-12-24T19:50:49.786688",
      "duration": "23.7739ms",
      "body": "PAYMENTS V2",
      "upstream_calls": [
        {
          "name": "currency-dc1",
          "uri": "http://localhost:9091",
          "type": "HTTP",
          "start_time": "2019-12-24T19:50:49.782486",
          "end_time": "2019-12-24T19:50:49.782897",
          "duration": "416.4µs",
          "body": "2 USD for 1 GBP",
          "code": 200
        }
      ],
      "code": 200
    }
  ],
  "code": 200
}

This also fixes a few broken images. If you prefer, I can submit without the whitespace changes.

Thanks for the demo. This is immensely helpful.

@nicholasjackson
Copy link
Owner

Oh wow thank you so much for the PR, I totally missed this @eeeschwartz .

Will merge first thing

@gc-ss
Copy link

gc-ss commented Jul 8, 2021

Oh wow thank you so much for the PR, I totally missed this @eeeschwartz .

Will merge first thing

@nicholasjackson I am reading up on gateways and saw that this PR updates some of the gateways config - so are we good to merge this to master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants