Merge pull request #5 from nicolasmure/code-review

code review

.travis.yml

@@ -1,15 +1,18 @@
 language: php
-php:
-    - '5.3'
-    - '7.0'
 
-env:
-    - SYMFONY_VERSION="2.4.*"
-    - SYMFONY_VERSION="3.0.*"
+matrix:
+  include:
+    - php: 5.3
+      env:
+        - SYMFONY_VERSION='2.5.*'
+    - php: 7.0
+      env:
+        - SYMFONY_VERSION='3.0.*'
 
 before_install:
     - mkdir -p build/logs
     - composer self-update
+    - sh -c 'if [ "$SYMFONY_VERSION" != "" ]; then composer require --dev --no-update symfony/symfony=$SYMFONY_VERSION; fi;'
 
 install:
     - composer require satooshi/php-coveralls '~1.0'

Tests/Unit/CrawlerDetect/CrawlerDetectTest.php

@@ -11,7 +11,7 @@ class CrawlerDetectTest extends TestCase
     private $browserUA = 'Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0';
     private $crawlerUA = 'Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)';
 
-    public function testRequestNotFromACrawler()
+    public function testBrowserRequest()
     {
         $rsMock = $this->getRequestStackMockWithMasterRequest($this->browserUA);
 
@@ -22,7 +22,7 @@ public function testRequestNotFromACrawler()
         $this->assertTrue($crawlerDetect->isCrawler($this->crawlerUA));
     }
 
-    public function testRequestFromACrawler()
+    public function testCrawlerRequest()
     {
         $rsMock = $this->getRequestStackMockWithMasterRequest($this->crawlerUA);
 

composer.json

@@ -13,7 +13,7 @@
     ],
     "require": {
         "php": ">=5.3.0",
-        "symfony/framework-bundle": "~2.4|~3.0",
+        "symfony/framework-bundle": "~2.5|~3.0",
         "jaybizzle/crawler-detect": "1.*"
     },
     "autoload": {