Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tsan happy with running(thr: Thread): bool proc #24603

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

change running to take var, otherwise we might get a copy?

2e8d39c
Select commit
Loading
Failed to load commit list.
Open

make tsan happy with running(thr: Thread): bool proc #24603

change running to take var, otherwise we might get a copy?
2e8d39c
Select commit
Loading
Failed to load commit list.
Azure Pipelines / nim-lang.Nim failed Jan 8, 2025 in 53m 34s

Build #20250108.1 had test failures

Details

Tests

  • Failed: 110 (0.61%)
  • Passed: 8,513 (47.48%)
  • Other: 9,305 (51.90%)
  • Total: 17,928

Annotations

Check failure on line 5603 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / nim-lang.Nim

Build log #L5603

Bash exited with code '1'.

Check failure on line 7078 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / nim-lang.Nim

Build log #L7078

Bash exited with code '1'.

Check failure on line 4971 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / nim-lang.Nim

Build log #L4971

Bash exited with code '1'.

Check failure on line 52190 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / nim-lang.Nim

Build log #L52190

Bash exited with code '1'.

Check failure on line 1 in tests/threads/t7172.nim c --threads:on --tlsEmulation:on

See this annotation in the file changed.

@azure-pipelines azure-pipelines / nim-lang.Nim

tests/threads/t7172.nim c --threads:on --tlsEmulation:on

Failure: reExitcodesDiffer
Expected:
exitcode: 0

Gotten:
exitcode: 1

Output:
In doStuff()
In initProcess()
TEST
No stack traceback available
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

Check failure on line 1 in tests/threads/t7172.nim c --threads:on --tlsEmulation:on

See this annotation in the file changed.

@azure-pipelines azure-pipelines / nim-lang.Nim

tests/threads/t7172.nim c --threads:on --tlsEmulation:on

Failure: reExitcodesDiffer
Expected:


Gotten:
$ /Users/runner/work/1/s/bin/nim c --hints:on -d:testing --nimblePath:build/deps/pkgs2   --threads:on --tlsEmulation:on --nimCache:nimcache/tests/threads/t7172.nim_845939c5cd4abd371ce2ea60d92b485c  tests/threads/t7172.nim
Hint: used config file '/Users/runner/work/1/s/config/nim.cfg' [Conf]
Hint: used config file '/Users/runner/work/1/s/config/config.nims' [Conf]
Hint: used config file '/Users/runner/work/1/s/tests/config.nims' [Conf]
Hint: used config file '/Users/runner/work/1/s/tests/threads/nim.cfg' [Conf]
t7172.nim(22, 16) Warning: use explicit initialization of 'thread' for clarity [Uninit]
CC: ../../lib/system/exceptions.nim
CC: ../../lib/std/private/threadtypes.nim
CC: ../../lib/std/private/digitsutils.nim
CC: ../../lib/std/assertions.nim
CC: ../../lib/system/dollars.nim
CC: ../../lib/std/typedthreads.nim
CC: ../../lib/system.nim
CC: ../../lib/posix/posix.nim
CC: ../../lib/pure/times.nim
CC: ../../lib/std/cmdline.nim
CC: ../../lib/pure/os.nim
CC: t7172.nim
Hint:  [Link]
Hint: mm: orc; threads: on; opt: none (DEBUG BUILD, `-d:release` generates faster code)
63915 lines; 2.396s; 91.574MiB peakmem; proj: t7172; out: t7172 [SuccessX]

Check failure on line 1 in tests/threads/threadex.nim c --threads:on --tlsEmulation:on

See this annotation in the file changed.

@azure-pipelines azure-pipelines / nim-lang.Nim

tests/threads/threadex.nim c --threads:on --tlsEmulation:on

Failure: reExitcodesDiffer
Expected:
exitcode: 0

Gotten:
exitcode: 1

Output:
No stack traceback available
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

Check failure on line 1 in tests/threads/threadex.nim c --threads:on --tlsEmulation:on

See this annotation in the file changed.

@azure-pipelines azure-pipelines / nim-lang.Nim

tests/threads/threadex.nim c --threads:on --tlsEmulation:on

Failure: reExitcodesDiffer
Expected:


Gotten:
$ /Users/runner/work/1/s/bin/nim c --hints:on -d:testing --nimblePath:build/deps/pkgs2   --threads:on --tlsEmulation:on --nimCache:nimcache/tests/threads/threadex.nim_845939c5cd4abd371ce2ea60d92b485c  tests/threads/threadex.nim
Hint: used config file '/Users/runner/work/1/s/config/nim.cfg' [Conf]
Hint: used config file '/Users/runner/work/1/s/config/config.nims' [Conf]
Hint: used config file '/Users/runner/work/1/s/tests/config.nims' [Conf]
Hint: used config file '/Users/runner/work/1/s/tests/threads/nim.cfg' [Conf]
threadex.nim(35, 5) Warning: use explicit initialization of 'm' for clarity [Uninit]
CC: ../../lib/system/exceptions.nim
CC: ../../lib/std/private/threadtypes.nim
CC: ../../lib/std/private/digitsutils.nim
CC: ../../lib/std/assertions.nim
CC: ../../lib/system/dollars.nim
CC: ../../lib/std/typedthreads.nim
CC: ../../lib/std/syncio.nim
CC: ../../lib/system.nim
CC: threadex.nim
Hint:  [Link]
Hint: mm: orc; threads: on; opt: none (DEBUG BUILD, `-d:release` generates faster code)
39277 lines; 1.134s; 47.734MiB peakmem; proj: threadex; out: threadex [SuccessX]