Enable macros to use certain things from the OS module when the target OS is not supported #24639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Jan 27, 2025
…t OS is not supported (#24639) Essentially this PR removes the `{.error.}` pragmas littered around in the OS module and submodules which prevents them from being imported if the target OS is not supported. This made it impossible to use certain supported features of the OS module in macros from a supported host OS. Instead of the `{.error.}` pragmas the `oscommon` module now has a constant `supportedSystem` which is false in the cases where the `{.error.}` pragmas where generated. All procedures which can't be run by macros is also not declared when `supportedSystem` is false. It would be possible to create dummy versions of the omitted functions with an `{.error.}` pragma that would trigger upon their use, but this is currently not done. This properly fixes #19414 (cherry picked from commit 1f9cac1)
https://github.com/nim-lang/nightlies/actions/runs/12980447170/job/36197485904 It seems to break nightlies |
|
Created a new PR to fix this issue: #24652 |
narimiran
pushed a commit
that referenced
this pull request
Jan 27, 2025
This should fix ringabouts comment here: #24639 (comment) I wasn't aware that `nintendoswitch` and `posix` would be active at the same time, so I falsely inverted a check.
narimiran
pushed a commit
that referenced
this pull request
Jan 27, 2025
This should fix ringabouts comment here: #24639 (comment) I wasn't aware that `nintendoswitch` and `posix` would be active at the same time, so I falsely inverted a check. (cherry picked from commit cab3342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially this PR removes the
{.error.}pragmas littered around in the OS module and submodules which prevents them from being imported if the target OS is not supported. This made it impossible to use certain supported features of the OS module in macros from a supported host OS. Instead of the{.error.}pragmas theoscommonmodule now has a constantsupportedSystemwhich is false in the cases where the{.error.}pragmas where generated. All procedures which can't be run by macros is also not declared whensupportedSystemis false.It would be possible to create dummy versions of the omitted functions with an
{.error.}pragma that would trigger upon their use, but this is currently not done.This properly fixes #19414