Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1206 #1209, Update XSSFRowColShifter.cs and MultiOperandNumericFunction.cs #1210

Closed
wants to merge 2 commits into from

Conversation

TimLee88
Copy link
Contributor

@TimLee88 TimLee88 commented Nov 7, 2023

See issue #1206 #1209

Set DEFAULT_MAX_NUM_OPERANDS as MaxFunctionArgs of Excel 2007
@Bykiev
Copy link
Collaborator

Bykiev commented Nov 8, 2023

it'll be better to open a separate PR for each issue

@TimLee88 TimLee88 changed the title Fix #1206 , Update XSSFRowColShifter.cs Fix #1206 #1209, Update XSSFRowColShifter.cs and MultiOperandNumericFunction.cs Nov 8, 2023
@TimLee88
Copy link
Contributor Author

TimLee88 commented Nov 8, 2023

@Bykiev Sorry, this is my first PR, I don't know how to split it ...

@tonyqus
Copy link
Member

tonyqus commented Nov 8, 2023

@TimLee88 Please create different branch for each PR instead of directly using master branch. And then you can split your PRs.

I'll close this PR first.

@tonyqus tonyqus closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants