Some patches ported from poi #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly hides the first column
…row that contains the comment is deleted; patch and file contributed by Greg Woolsey
…ernal workbook references with a quoted sheet name
|
@antony-liu Hi Antony, welcome back. Please DON'T merge any other PR to master until the end of March because I'm releasing 2.7.0. It's just RC version for now. |
Bykiev
reviewed
Mar 12, 2024
| } | ||
| finally | ||
| { | ||
| fout.Close(); |
There was a problem hiding this comment.
Do we need to call Close explicitly here, when it was already managed by using statement?
There was a problem hiding this comment.
You are right. The code was just copied from POI, I will remove it.
OK, I got it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.