poi: #60626 - ArrayIndexOutOfBoundsException in EvilUnclosedBRFixingInputStream #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyqus
reviewed
Dec 12, 2024
| @@ -116,7 +117,7 @@ internal void Read(Stream is1) | |||
| //Stream vmlsm = new EvilUnclosedBRFixingInputStream(is1); --TODO:: add later | |||
|
|
|||
| doc.LoadXml( | |||
| data.Replace("<br>","").Replace("</br>", "") | |||
| data.Replace("<br>", "<br/>").Replace("</br>", "<br/>") | |||
There was a problem hiding this comment.
Don't change this code. I remember this is used to fix something.
There was a problem hiding this comment.
There were issues with the previous fix. This fix has added the test case TestEvilUnclosedBRFixing, the previous fix make it failed. I think it was used to fix the Unclosed BR tag issue.
The Unclosed BR tag should not be deleted, but rather it should be corrected.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poi: #60626 - ArrayIndexOutOfBoundsException in EvilUnclosedBRFixingInputStream