Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route-rules): add support for both the path and params #2954

Draft
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

snarcraft
Copy link

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • [x ] ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Wouldn’t it be beneficial to support both the path and query parameters in proxy and redirection route rules?
I may not fully understand the entire scope, so I’d greatly appreciate any clarification if I’m mistaken.
However, in my opinion, supporting both would be highly advantageous. Currently, I need to create a patch for each project to implement this functionality.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@snarcraft snarcraft requested a review from pi0 as a code owner December 23, 2024 12:45
@pi0
Copy link
Member

pi0 commented Dec 23, 2024

Can you please open an issue + reproduction of the unsupported case first? πŸ™πŸΌ

@pi0 pi0 marked this pull request as draft December 23, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants