support IPv6 address when using --extra-files #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mic92 would you have an opportunity to review this? |
phaer
reviewed
Nov 8, 2023
| @@ -447,11 +447,21 @@ if [[ -n ${extra_files-} ]]; then | |||
| if [[ -d $extra_files ]]; then | |||
| extra_files="$extra_files/" | |||
| fi | |||
| # If `ssh_host` is an IPv6 address, we need to wrap it in brackets. | |||
| if [[ $ssh_host =~ ^[0-9a-fA-F:]+$ ]]; then | |||
There was a problem hiding this comment.
This regex could result in quite a few false positives IMO.
There was a problem hiding this comment.
Yes, if you name your machine: caffeebabe
phaer
requested changes
Nov 8, 2023
There was a problem hiding this comment.
Are you sure this is needed? I think rsync supports square brackets around ipv4 addresses and hostnames as well for exactly this reason and quick testing seems to support that hypothesis, so i.e.:
rsync_destination="root@[${ssh_host}]:/mnt/"
should work the same?
|
Lack of response. Please re-open if you plan to continue working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246.
I successfully deployed to an IPv4 and IPv6 host, so it doesn't break anything and it does fix the linked issue.