[feat] remove -t parameter and replace it with a check of whether it's tty #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good otherwise. |
|
Yeah I’ll probably get the chance to try it out soon, I’ll report back then. :) |
|
it works... |
zimbatm
reviewed
Jan 1, 2024
src/nixos-anywhere.sh
Outdated
Comment on lines
109
to
111
| -t | --tty) | ||
| ssh_tty_param="-t" | ||
| ;; |
There was a problem hiding this comment.
This is useful for tools that might want to wrap up this program and interact with it as if they had a TTY.
There was a problem hiding this comment.
I would leave it in if @Mic92 and @RaitoBezarius don't have anything against it.
Mic92
force-pushed
the
mangoiv/remove-dash-t
branch
from
ce88f49 to
1fec12a
Compare
Mic92
force-pushed
the
mangoiv/remove-dash-t
branch
from
1fec12a to
4fb809d
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 4c94cec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested the manual version yet...