Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(src/nixos-anywhere): use tar and ssh instead of rsync #316

Closed
wants to merge 0 commits into from

Conversation

Prince213
Copy link
Contributor

@Prince213 Prince213 commented May 9, 2024

Resolves #260. Closes #295.

This PR replaces use of rsync with a combination of tar and ssh. It's an alternative solution to #295, but it avoid the problem as per #295 (comment). Also, directly copying with scp will not preserve symbolic links, which isn't a issue with this PR.

One notable change is that extra_files is assumed to be a directory, though there doesn't seem to be much case for it to be (multiple) files (checked within the repo), which isn't useful anyway because the exact path can't be easily specified (see also #283).

@Prince213 Prince213 marked this pull request as ready for review May 9, 2024 16:38
@Prince213
Copy link
Contributor Author

@Mic92 please take a look.

@Mic92
Copy link
Member

Mic92 commented May 26, 2024

@mergify queue

@Mic92 Mic92 mentioned this pull request May 26, 2024
Copy link
Contributor

mergify bot commented May 26, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Member

Mic92 commented May 26, 2024

@Mergifyio rebase

Copy link
Contributor

mergify bot commented May 26, 2024

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@Prince213 needs to authorize modification on its head branch.

@Prince213
Copy link
Contributor Author

Prince213 commented May 26, 2024

Sorry for that @Mic92, authorized now. Please try again, it should now work.

Edit: Never mind, just saw #325.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rsync command not found with 23.11 nixos image
2 participants