feat(src/nixos-anywhere): use tar and ssh instead of rsync #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #260. Closes #295.
This PR replaces use of rsync with a combination of tar and ssh. It's an alternative solution to #295, but it avoid the problem as per #295 (comment). Also, directly copying with scp will not preserve symbolic links, which isn't a issue with this PR.
One notable change is that
extra_files
is assumed to be a directory, though there doesn't seem to be much case for it to be (multiple) files (checked within the repo), which isn't useful anyway because the exact path can't be easily specified (see also #283).