Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to set ownership of extraFiles #444

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add option to set ownership of extraFiles #444

wants to merge 4 commits into from

Conversation

costowell
Copy link

I was in need to setting ownership for some extra files and will probably need it more going forward so I added a --chown option and documentation too.

Mic92
Mic92 reviewed Dec 23, 2024
View reviewed changes
docs/reference.md
@@ -49,7 +49,10 @@ Options:
copy over existing /etc/ssh/ssh_host_* host keys to the installation
* --extra-files <path>
contents of local <path> are recursively copied to the root (/) of the new NixOS installation. Existing files are overwritten
Copied files will be owned by root. See documentation for details.
Copied files will be owned by root unless specified by --chown option. See documentation for details.
* --chown <path> <ownership>
Copy link
Member

@Mic92 Mic92 Dec 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this parameter to our existing nixos test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@costowell
test: chown option
e453e31 
Signed-off-by: Cole Stowell <[email protected]>
@costowell costowell requested a review from Mic92 January 2, 2025 21:14
@Mic92
Copy link
Member

Mic92 commented Jan 7, 2025

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 7, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 7, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@costowell @Mic92