Skip to content

Commit

Permalink
Merge branch 'main' into upgrade-carbon-1.68.0
Browse files Browse the repository at this point in the history
  • Loading branch information
nmgokhale authored Oct 23, 2024
2 parents 32621ce + 89e8d63 commit 80a02f5
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ class TitleEditor extends Component {
</div>)
: null;
const icon = this.props.icon && typeof this.props.icon === "string"
? <Isvg className="properties-title-heading-icon" src={this.props.icon} />
? <Isvg className="properties-title-heading-icon" src={this.props.icon} aria-hidden="true" />
: null;
if (label || icon) {
heading = (<div className="properties-title-heading">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ class PaletteContentListItem extends React.Component {
icon = image;
} else if (typeof image === "string") {
icon = image.endsWith(".svg")
? <SVG src={image} className="palette-list-item-icon" draggable="false" />
? <SVG src={image} className="palette-list-item-icon" draggable="false" aria-hidden="true" />
: <img src={image} className="palette-list-item-icon" draggable="false" alt={""} />;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ class PaletteFlyoutContentCategory extends React.Component {
} else if (this.props.category.image.endsWith(".svg")) {
itemImage = (
<div>
<SVG src={this.props.category.image} className="palette-flyout-category-item-icon" draggable="false" />
<SVG src={this.props.category.image} className="palette-flyout-category-item-icon" draggable="false" aria-hidden="true" />
</div>
);
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ class PaletteFlyoutContentSearch extends React.Component {
// palette-flyout-search id added for hopscotch tours
<div className="palette-flyout-search-container" id="palette-flyout-search">
<Search
id="palette-flyout-search"
className="palette-flyout-search"
placeholder={placeHolder}
onChange={this.handleSearchStringChange}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ class ToolbarButtonItem extends React.Component {
}
const path = this.props.size === "sm" ? "M 29 29 L 29 23 23 29 Z" : "M 37 37 L 37 30 30 37 Z";
return (
<svg className="toolbar-tick-svg">
<svg className="toolbar-tick-svg" aria-hidden="true">
<path d={path} className="toolbar-tick-mark" />
</svg>
);
Expand Down
2 changes: 1 addition & 1 deletion canvas_modules/harness/src/client/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -2225,7 +2225,7 @@ class App extends React.Component {
{ action: "color-subpanel", iconEnabled: (<ColorPalette size={32} />), label: "Color picker", enable: true,
subPanel: ColorPicker, subPanelData: { clickActionHandler: (color) => window.alert("Color selected = " + color) } },
{ divider: true },
{ action: "save", iconEnabled: (<Save size={32} />), enable: true, tooltip: saveReloadTooltip }
{ action: "save", iconEnabled: (<Save size={32} />), label: "Save", enable: true, tooltip: saveReloadTooltip }
],
rightBar: [
{ divider: true },
Expand Down

0 comments on commit 80a02f5

Please sign in to comment.