-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK to Connector V5 #4
Update SDK to Connector V5 #4
Conversation
src/main/java/eu/enmeshed/model/requestItems/RequestItemGroup.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/Relationship.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/RelationshipAuditLog.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/RelationshipAuditLog.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/Relationship.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/RelationshipAuditLog.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/RelationshipAuditLog.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/RelationshipStaus.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The event consumption.outgoingRequestFromRelationshipCreationChangeCreatedAndCompleted
needs to be renamed to consumption.outgoingRequestFromRelationshipCreationCreatedAndCompleted
in the file WebhookTriggerNames.java
.
public static final String
OUTGOING_REQUEST_FROM_RELATIONSHIP_CREATION_CHANGE_CREATED_AND_COMPLETED =
"consumption.outgoingRequestFromRelationshipCreationChangeCreatedAndCompleted";
See also https://enmeshed.eu/integrate/migration-from-v4-to-v5#renamed-and-added-events.
Accordingly, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the README_dev.md
there are still RelationshipChanges that could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New content types must be dealt with in the future:
- As
MessageContent
, also theNotification
and the ArbitraryMessageContent can be used. - The content of a
RelationshipTemplate
can also be an ArbitraryRelationshipTemplateContent instead of a RelationshipTemplateContent. - The
creationContent
of aRelationship
can also be an ArbitraryRelationshipCreationContent instead of a RelationshipCreationContent.
src/main/java/eu/enmeshed/model/requestItems/RequestItemGroup.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/RelationshipAuditLog.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/RelationshipAuditLog.java
Outdated
Show resolved
Hide resolved
...in/java/eu/enmeshed/model/notificationItem/PeerSharedAttributeSucceededNotificationItem.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/notificationItem/NotificationItem.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/requestItems/RequestItemGroup.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Julian König <[email protected]>
...in/java/eu/enmeshed/model/notificationItem/PeerSharedAttributeSucceededNotificationItem.java
Outdated
Show resolved
Hide resolved
...in/java/eu/enmeshed/model/notificationItem/PeerSharedAttributeSucceededNotificationItem.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/relationships/Relationship.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/requestItems/ProposeAttributeRequestItem.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/requestItems/ReadAttributeRequestItem.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/requestItems/ShareAttributeRequestItem.java
Show resolved
Hide resolved
src/main/java/eu/enmeshed/model/requestItems/CreateAttributeRequestItem.java
Outdated
Show resolved
Hide resolved
@mbaboshyn Warning in the Build Pipeline:
please fix this. |
Is it relevant? I can't see such a warning, and there is no usage of the class in a type-safe way. |
I don't know why it is logged, but in general I am no fan to just ignore warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @britsta PTAL.
I will merge this now, but I have to do some fixes until I can release this. |
No description provided.