Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to Connector V5 #4

Merged
merged 17 commits into from
Sep 13, 2024

Conversation

mbaboshyn
Copy link
Contributor

No description provided.

@jkoenig134 jkoenig134 self-requested a review September 9, 2024 18:04
@jkoenig134 jkoenig134 changed the title [BE] Migrate DNA Enmeshed SDK changes to the new repository Update SDK to Connector V5 Sep 10, 2024
Copy link

@britsta britsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event consumption.outgoingRequestFromRelationshipCreationChangeCreatedAndCompleted needs to be renamed to consumption.outgoingRequestFromRelationshipCreationCreatedAndCompleted in the file WebhookTriggerNames.java.

public static final String
        OUTGOING_REQUEST_FROM_RELATIONSHIP_CREATION_CHANGE_CREATED_AND_COMPLETED =
            "consumption.outgoingRequestFromRelationshipCreationChangeCreatedAndCompleted";

See also https://enmeshed.eu/integrate/migration-from-v4-to-v5#renamed-and-added-events.

@britsta
Copy link

britsta commented Sep 11, 2024

The event consumption.outgoingRequestFromRelationshipCreationChangeCreatedAndCompleted needs to be renamed to consumption.outgoingRequestFromRelationshipCreationCreatedAndCompleted in the file WebhookTriggerNames.java.

public static final String
        OUTGOING_REQUEST_FROM_RELATIONSHIP_CREATION_CHANGE_CREATED_AND_COMPLETED =
            "consumption.outgoingRequestFromRelationshipCreationChangeCreatedAndCompleted";

See also https://enmeshed.eu/integrate/migration-from-v4-to-v5#renamed-and-added-events.

Accordingly, OUTGOING_REQUEST_FROM_RELATIONSHIP_CREATION_CHANGE_CREATED_AND_COMPLETED needs to be renamed in the files WebhookTriggerNames.java, WebhookTrigger.java and Webhook.java.

Copy link

@britsta britsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the README_dev.md there are still RelationshipChanges that could be removed.

Copy link

@britsta britsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New content types must be dealt with in the future:

See also https://enmeshed.eu/integrate/migration-from-v4-to-v5#new-mandatory-wrappers-for-non-standard-content-of-messages-relationshiptemplates-and-relationships.

README_dev.md Outdated Show resolved Hide resolved
Co-authored-by: Julian König <[email protected]>
README_dev.md Outdated Show resolved Hide resolved
@jkoenig134
Copy link
Member

@mbaboshyn Warning in the Build Pipeline:

src/main/java/eu/enmeshed/model/request/LocalRequestResponse.java: Some input files use unchecked or unsafe operations.

please fix this.

@mbaboshyn
Copy link
Contributor Author

@mbaboshyn Warning in the Build Pipeline:

src/main/java/eu/enmeshed/model/request/LocalRequestResponse.java: Some input files use unchecked or unsafe operations.

please fix this.

Is it relevant? I can't see such a warning, and there is no usage of the class in a type-safe way.

@jkoenig134
Copy link
Member

I don't know why it is logged, but in general I am no fan to just ignore warnings

Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @britsta PTAL.

@jkoenig134
Copy link
Member

I will merge this now, but I have to do some fixes until I can release this.

@jkoenig134 jkoenig134 merged commit faf95be into nmshd:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants