Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/implement request item derivation and properly use types #5

Merged

Conversation

jkoenig134
Copy link
Member

No description provided.

@jkoenig134 jkoenig134 requested a review from britsta September 13, 2024 14:28
@jkoenig134 jkoenig134 enabled auto-merge (squash) September 13, 2024 14:59
@britsta
Copy link

britsta commented Sep 16, 2024

I think the title of the PR "Fix/use implement request item derivation and properly use types" needs to be adjusted, the phrase "use implement request item derivation" has one verb too many.

@jkoenig134 jkoenig134 requested a review from britsta September 16, 2024 09:43
Copy link

@britsta britsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@jkoenig134 jkoenig134 disabled auto-merge September 16, 2024 10:13
@jkoenig134 jkoenig134 merged commit e824fe3 into main Sep 16, 2024
2 checks passed
@jkoenig134 jkoenig134 deleted the fix/use-implement-request-item-derivation-and-properly-use-types branch September 16, 2024 10:15
@jkoenig134 jkoenig134 changed the title Fix/use implement request item derivation and properly use types Fix/implement request item derivation and properly use types Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants