-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/remove unused pages #250
base: main
Are you sure you want to change the base?
Conversation
the pr is called remove unused pages - I only see diagrams removed. Is this not finished or named confusingly? Edit: ignore this, I only saw the changes from last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @britsta do you want to have another look?
I'll take a quick look at it now and then approve it or comment on it. |
thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the prerelease files that we should not delete IMO (see other comments), there are some files here that I agree in principle to delete within the documentation repository, as this is not intended as a storage for drafts, but which nevertheless contain some valuable content. I will store this content, which we could include elsewhere in the documentation, on suitable Confluence pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove this file. It will automatically created anyway the next time the Excel script is running. The content here was written 5 months ago and it is quite possible that this prerelease documentation is currently not published due to a missing entry ("true" in the "published" column) in the Excel table. I don't think it gives us any advantage to delete this content here if the file is going to be recreated anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove this file. It will automatically created anyway the next time the Excel script is running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove this file. It will automatically created anyway the next time the Excel script is running. The content here was written 5 months ago and it is quite possible that this prerelease documentation is currently not published due to a missing entry ("true" in the "published" column) in the Excel table. I don't think it gives us any advantage to delete this content here if the file is going to be recreated anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove this file. It will automatically created anyway the next time the Excel script is running. The content here was written 5 months ago and it is quite possible that this prerelease documentation is currently not published due to a missing entry ("true" in the "published" column) in the Excel table. I don't think it gives us any advantage to delete this content here if the file is going to be recreated anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove this file. It will automatically created anyway the next time the Excel script is running. The content here was written 5 months ago and it is quite possible that this prerelease documentation is currently not published due to a missing entry ("true" in the "published" column) in the Excel table. I don't think it gives us any advantage to delete this content here if the file is going to be recreated anyway.
I selected them for deletion because the documentation has grown in a way that there would be no place for them anymore without a major rewrite (mostly swallowed by the Working with Requests section), and there was no special content that would be an effort to recreate. And the excel can always be adapted, in fact I'd like to add a column there that the pages where nothing is on them aren't there (or they're put into gitignore) |
You are probably right that these contents do not quite fit into the current state of the documentation. However, I think that is the reason why they were declared as prereleases and then they can be revised at a later date. I remember that there was a reason why we wanted to have at least a little bit of content on some scenario pages so that the Integrators could at least find a little bit of information there as we expose links to these preleases on certain websites.
That would be an option. We should discuss this again separately. |
I will transform this to a draft, b/c it seems like it wasn't properly discussed if this should happen and if yes in which extent. |
No description provided.