Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code #415

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Remove unused code #415

merged 3 commits into from
Feb 5, 2025

Conversation

jkoenig134
Copy link
Member

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

This was an artifact from the old (cordova) app and is now handled completely different.

@jkoenig134 jkoenig134 enabled auto-merge (squash) February 5, 2025 10:16
@jkoenig134 jkoenig134 added the chore Some routine work like updating dependencies label Feb 5, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
packages/app-runtime/src/AppConfig.ts 100.00% <ø> (ø)
packages/app-runtime/src/AppRuntime.ts 77.97% <ø> (-0.14%) ⬇️
...ackages/app-runtime/src/modules/appEvents/index.ts 100.00% <ø> (ø)
packages/app-runtime/src/natives/events/index.ts 100.00% <ø> (ø)

@jkoenig134 jkoenig134 merged commit b0cf129 into main Feb 5, 2025
15 of 16 checks passed
@jkoenig134 jkoenig134 deleted the remove-unused-code branch February 5, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebbi08 sebbi08 sebbi08 approved these changes

@Milena-Czierlinski Milena-Czierlinski Awaiting requested review from Milena-Czierlinski

Assignees
No one assigned
Labels
chore Some routine work like updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoenig134 @sebbi08