remove gulp-eslint (new-xkit#2012)

* remove gulp-eslint, gulp lint command

* update build docs

.github/workflows/gh-pages.yml

@@ -11,35 +11,46 @@ on:
 jobs:
   build:
     name: Autobuild extensions
-    if: github.repository == 'new-xkit/XKit'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout
+        uses: actions/checkout@v2
         with:
           fetch-depth: 0
-      - name: Use Node.js 12
-        uses: actions/setup-node@v1
+
+      - name: Setup Node.js environment
+        uses: actions/[email protected]
         with:
-          node-version: 12
+          node-version: 14
+
       - name: Configure git
         run: |
           git config --global user.name "github-actions"
           git config --global user.email "github-actions[bot]@users.noreply.github.com"
+
       - name: Fetch and reset gh-pages
         run: |
           git remote set-branches --add origin gh-pages
           git fetch
           git checkout -f -t -b gh-pages origin/gh-pages
           git reset --hard master
+
       - name: Install dependencies
         run: npm ci
+
+      - name: Run tests
+        run: npm test
+
       - name: Install gulp-cli
         run: npm install gulp-cli
+
       - name: Build distribution
         run: gulp build
+
       - name: Commit changes
         run: |
           git add --force Extensions/
           git commit -m 'Rebuild Distribution'
+
       - name: Force-push to gh-pages
         run: git push -f

docs/contributing/Build-XKit.md

@@ -26,7 +26,7 @@ Serving extensions and themes locally is useful for rapid development without re
 
 #### `npm test`
 
-Shortcut for [`gulp lint:scripts`](#gulp-lintscripts).
+Shortcut for `eslint .`.
 
 #### `npm run dev`
 
@@ -42,17 +42,7 @@ Uses `web-ext build` with the necessary file exclusions to build and pack the We
 
 The default task.
 
-See also: [`gulp lint`](#gulp-lint).
-
-#### `gulp lint`
-
-Top-level linting task.
-
-See also [`gulp lint:scripts`](#gulp-lintscripts).
-
-#### `gulp lint:scripts`
-
-Lints JavaScript files using ESLint, and reports the output.
+See also: [`gulp build`](#gulp-build).
 
 #### `gulp build`
 

gulpfile.js

@@ -1,12 +1,10 @@
 /* eslint-env node */
 'use strict';
 
-var cache = require('gulp-cached'),
-	connect = require('connect'),
+var connect = require('connect'),
 	connectLogger = require('morgan'),
 	connectStatic = require('serve-static'),
 	del = require('del'),
-	eslint = require('gulp-eslint'),
 	fs = require('fs'),
 	gulp = require('gulp'),
 	gutil = require('gulp-util'),
@@ -40,23 +38,7 @@ gulp.task('clean:themes', function(cb) {
 
 gulp.task('clean', gulp.series('clean:extensions', 'clean:themes'));
 
-gulp.task('lint:scripts', function() {
-	var src = [].concat(
-		paths.scripts.dev,
-		paths.scripts.core,
-		paths.scripts.extensions
-	);
-
-	return gulp.src(src)
-		.pipe(cache('lint:scripts'))
-		.pipe(eslint())
-		.pipe(eslint.format())
-		.pipe(eslint.failAfterError());
-});
-
-gulp.task('lint', gulp.series('lint:scripts'));
-
-gulp.task('build:extensions', gulp.series('lint:scripts', 'clean:extensions', function() {
+gulp.task('build:extensions', gulp.series('clean:extensions', function() {
 	var extensionBuilder = require('./dev/builders/extension');
 	return gulp.src(paths.scripts.extensions)
 		.pipe(extensionBuilder())
@@ -125,4 +107,4 @@ gulp.task('server', gulp.series('build', function(callback) {
 	});
 }));
 
-gulp.task('default', gulp.series('lint'));
+gulp.task('default', gulp.series('build'));

package.json

@@ -17,8 +17,6 @@
     "del": "^1.2.1",
     "eslint": "^3.19.0",
     "gulp": "^4.0.2",
-    "gulp-cached": "^1.1.1",
-    "gulp-eslint": "^3.0.1",
     "gulp-util": "^3.0.8",
     "merge-stream": "^0.1.8",
     "morgan": "^1.10.0",