Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update SWC to v1.10.2 #138

Closed
wants to merge 4 commits into from

Conversation

github-actions[bot]
Copy link

This PR updates SWC to v1.10.2.
View the SWC changelog for more information.

@marco-ippolito marco-ippolito deleted the chore/update-swc-1.10.2 branch December 26, 2024 17:37
@marco-ippolito marco-ippolito restored the chore/update-swc-1.10.2 branch December 26, 2024 17:50
@marco-ippolito
Copy link
Member

marco-ippolito commented Dec 26, 2024

@kdy1 I think there is a bug, the swc transformation removes the ; for no reason 2c96bdc
This is the test:

test("should not polyfill using Symbol.Dispose", (t) => {
	const inputCode = `
	using r = 0;`;
	const { code } = transformSync(inputCode, {
		mode: "transform",
		sourceMap: true,
	});
	t.assert.snapshot(code);
});

Output:

using r = 0

The semicolon is missing

@kdy1
Copy link
Member

kdy1 commented Dec 26, 2024 via email

@kdy1
Copy link
Member

kdy1 commented Dec 27, 2024

I think swc-project/swc#9798 is the cause.
cc @dsherret

@kdy1
Copy link
Member

kdy1 commented Dec 27, 2024

I made swc-project/swc#9815

@kdy1
Copy link
Member

kdy1 commented Dec 28, 2024

I fixed the issue and published a new version

@marco-ippolito
Copy link
Member

closed in favor of #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants