Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fixed license path and CMake minimum version. #566

Merged
merged 1 commit into from
Jan 16, 2025
Merged

chore: Fixed license path and CMake minimum version. #566

merged 1 commit into from
Jan 16, 2025

Conversation

ShogunPanda
Copy link
Contributor

Fixes #564 and #542.

@ShogunPanda ShogunPanda requested a review from mcollina January 13, 2025 08:06
This was referenced Jan 13, 2025
Closed
Closed
mcollina
mcollina approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPanda ShogunPanda merged commit 10c0019 into nodejs:main Jan 16, 2025
9 of 11 checks passed
@ShogunPanda ShogunPanda deleted the minor-fixes branch January 16, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make release license filename
2 participants
@ShogunPanda @mcollina