-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve debugger custom test #55767
base: main
Are you sure you want to change the base?
test: improve debugger custom test #55767
Conversation
f939522
to
1d905c4
Compare
1d905c4
to
fbcd2ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55767 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.01%
==========================================
Files 654 654
Lines 187752 187752
Branches 36125 36127 +2
==========================================
- Hits 165993 165983 -10
- Misses 15000 15007 +7
- Partials 6759 6762 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only see a refactor to use node:test
for no good reason. There is only a simple test, no subtests. This is not an improvement in my opinion.
I agree with your comment that the change does not provide a significant contribution to the test file however, the motivation behind this change was to establish a standardized structure in the codebase and transition to the modern |
There is already a request for changes so it does not make much sense to add the "blocked" label. Feel free to add it to the other PRs. |
I tried to improve this test using node:test