test: add ts eval snapshots #56358
Closed
test: add ts eval snapshots #56358
+106
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56358 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.01%
==========================================
Files 657 657
Lines 190738 190719 -19
Branches 36607 36603 -4
==========================================
- Hits 168886 168862 -24
- Misses 15026 15033 +7
+ Partials 6826 6824 -2
|
marco-ippolito
added
dont-land-on-v18.x
marco-ippolito
force-pushed
the
test-eval-messages
branch
from
0986177 to
be5e243
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
|
Its a real failure on windows arm64 😭😭😭😭😭 |
jasnell
approved these changes
Dec 28, 2024
anonrig
approved these changes
Dec 28, 2024
marco-ippolito
force-pushed
the
test-eval-messages
branch
from
be5e243 to
f9e7cc4
Compare
marco-ippolito
added
commit-queue
github-actions
bot
removed
the
request-ci
marco-ippolito
force-pushed
the
test-eval-messages
branch
from
f9e7cc4 to
0c6a364
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
JakobJingleheimer
approved these changes
Dec 30, 2024
Comment on lines
+87
to
+94
| const evalFunction = () => runScriptInContext(name, | ||
| body, | ||
| breakFirstLine, | ||
| print, | ||
| module, | ||
| baseUrl, | ||
| undefined, | ||
| origModule); |
There was a problem hiding this comment.
What the heck is happening here?
Suggested change
| const evalFunction = () => runScriptInContext(name, | |
| body, | |
| breakFirstLine, | |
| print, | |
| module, | |
| baseUrl, | |
| undefined, | |
| origModule); | |
| const evalFunction = () => runScriptInContext( | |
| name, | |
| body, | |
| breakFirstLine, | |
| print, | |
| module, | |
| baseUrl, | |
| undefined, | |
| origModule, | |
| ); |
There was a problem hiding this comment.
Its the formatter 🤷 I run make lint-js-fix and it formats it that way
Comment on lines
+285
to
+292
| const evalFunction = () => runScriptInContext(name, | ||
| sourceToRun, | ||
| breakFirstLine, | ||
| print, | ||
| module, | ||
| baseUrl, | ||
| compiledScript, | ||
| origModule); |
There was a problem hiding this comment.
Same
Suggested change
| const evalFunction = () => runScriptInContext(name, | |
| sourceToRun, | |
| breakFirstLine, | |
| print, | |
| module, | |
| baseUrl, | |
| compiledScript, | |
| origModule); | |
| const evalFunction = () => runScriptInContext( | |
| name, | |
| sourceToRun, | |
| breakFirstLine, | |
| print, | |
| module, | |
| baseUrl, | |
| compiledScript, | |
| origModule, | |
| ); |
| 'const foo: string = 10;', | ||
| 'function foo(){};foo<Number>(1);', | ||
| 'interface Foo{};const foo;', | ||
| 'function foo(){ await Promise.resolve(1)};', |
There was a problem hiding this comment.
nit: this seems a bit convoluted
Suggested change
| 'function foo(){ await Promise.resolve(1)};', | |
| 'async function foo(){ return 1 };', |
or
Suggested change
| 'function foo(){ await Promise.resolve(1)};', | |
| 'const foo = async () => 1;', |
There was a problem hiding this comment.
Its not the same thing, its convoluted to create a syntax error
marco-ippolito
added
commit-queue-rebase
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
PR-URL: #56358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
|
Landed in d2af881...b3f82fe |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
PR-URL: #56358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
PR-URL: #56358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some light refactoring and printing error message from
--evalwith ts