Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix faulty YAML metadata #56508

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 7, 2025

To fix the linter on main

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 7, 2025
@aduh95 aduh95 requested a review from ruyadorno January 7, 2025 20:40
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 7, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5119049 into nodejs:main Jan 7, 2025
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5119049

@aduh95 aduh95 deleted the fix-linter branch January 7, 2025 22:18
ruyadorno added a commit to nodejs/node-core-utils that referenced this pull request Jan 8, 2025
After two consecutive releases in which I mistakely pushed a broken
release commit to main, I'm convinced that the process needs
improvement.

This changeset proposes to add a reminder to `git node release promote`
to lint markdown files prior to pushing branches to upstream remote.

Refs: nodejs/node@a344300
Refs: nodejs/node#56508
ruyadorno added a commit to nodejs/node-core-utils that referenced this pull request Jan 8, 2025
After two consecutive releases in which I mistakely pushed a broken
release commit to main, I'm convinced that the process needs
improvement.

This changeset proposes to add a reminder to `git node release promote`
to lint markdown files prior to pushing branches to upstream remote.

Refs: nodejs/node@a344300
Refs: nodejs/node#56508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants