Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try debugging flaky abort test #3732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Try debugging flaky abort test #3732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/fetch/long-lived-abort-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
t.after(closeServerAsPromise(server))

let warningEmitted = false
function onWarning () {
function onWarning (warning) {
console.error(warning)
warningEmitted = true
}
process.on('warning', onWarning)
Expand All @@ -44,5 +45,5 @@
await res.text()
}

strictEqual(warningEmitted, false)

Check failure on line 48 in test/fetch/long-lived-abort-controller.js

View workflow job for this annotation

GitHub Actions / test (22, ubuntu-latest) / Test with Node.js 22 on ubuntu-latest

long-lived-abort-controller 

[Error [ERR_TEST_FAILURE]: Expected values to be strictly equal:

true !== false
] {
  code: 'ERR_TEST_FAILURE',
  failureType: 'testCodeFailure',
  cause: AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  
  true !== false
  
      at TestContext.<anonymous> (/home/runner/work/undici/undici/test/fetch/long-lived-abort-controller.js:48:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async Test.run (node:internal/test_runner/test:931:9)
      at async startSubtestAfterBootstrap (node:internal/test_runner/harness:289:3) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: true,
    expected: false,
    operator: 'strictEqual'
  }
}
})
Loading