-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add
correct-ts-specifiers
(#7)
- Loading branch information
1 parent
1d6bd57
commit 33bb235
Showing
80 changed files
with
9,507 additions
and
97 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{ | ||
"$schema": "https://codemod-utils.s3.us-west-1.amazonaws.com/configuration_schema.json", | ||
"name": "correct-ts-specifiers", | ||
"version": "1.0.0", | ||
"engine": "workflow", | ||
"private": false, | ||
"arguments": [], | ||
"meta": { | ||
"git": "https://github.com/nodejs/userland-migrations/tree/main/recipes/correct-ts-specifiers", | ||
"tags": [ | ||
"esm", | ||
"import", | ||
"node", | ||
"typescript" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
# Correct TypeScript Specifiers | ||
|
||
This package transforms import specifiers in source-code from the broken state TypeScript's compiler (`tsc`) required (prior TypeScript v5.7 RC) into proper ones. This is useful when source-code is processed by standards-compliant software like Node.js. This is a one-and-done process, and the updated source-code should be committed to your version control (ex git); thereafter, source-code import statements should be authored compliant with the ECMAScript (JavaScript) standard. | ||
|
||
> [!TIP] | ||
> Those using `tsc` to compile will need to enable [`rewriteRelativeImportExtensions`](https://www.typescriptlang.org/tsconfig/#rewriteRelativeImportExtensions); using `tsc` for only type-checking (ex via a lint/test step like `npm run test:types`) needs [`allowImportingTsExtensions`](https://www.typescriptlang.org/tsconfig/#allowImportingTsExtensions) (and some additional compile options—see the cited documentation); | ||
This package does not just blindly find & replace file extensions within specifiers: It confirms that the replacement specifier actually exists; in ambiguous cases (such as two files with the same basename in the same location but different relevant file extensions like `/tmp/foo.js` and `/tmp/foo.ts`), it logs an error, skips that specifier, and continues processing. | ||
|
||
> [!CAUTION] | ||
> This package does not confirm that imported modules contain the desired export(s). This _shouldn't_ actually ever result in a problem because ambiguous cases are skipped (so if there is a problem, it existed before the migration started). Merely running your source-code after the mirgration completes will confirm all is well (if there are problems, node will error, citing the problems). | ||
> [!TIP] | ||
> Node.js requires the `type` keyword be present on type imports. For own code, this package usually handles that. However, in some cases and for node modules, it does not. Robust tooling already exists that will automatically fix this, such as [`consistent-type-imports` via typescript-lint](https://typescript-eslint.io/rules/consistent-type-imports) and [`use-import-type` via biome](https://biomejs.dev/linter/rules/use-import-type/). If your source code needs that, first run this codemod and then one of those fixers. | ||
## Running | ||
|
||
> [!CAUTION] | ||
> This will change your source-code. Commit any unsaved changes before running this package. | ||
```sh | ||
NODE_OPTIONS="--experimental-import-meta-resolve" \ | ||
npx codemod@latest correct-ts-specifiers | ||
``` | ||
|
||
### Monorepos | ||
|
||
For best results, run this _within_ each workspace of the monorepo. | ||
|
||
```text | ||
project-root/ | ||
├ workspaces/ | ||
├ foo/ ←--------- RUN HERE | ||
├ … | ||
├ package.json | ||
└ tsconfig.json | ||
└ bar/ ←--------- RUN HERE | ||
├ … | ||
├ package.json | ||
└ tsconfig.json | ||
└ utils/ ←--------- RUN HERE | ||
├ qux.js | ||
└ zed.js | ||
``` | ||
|
||
## Supported cases | ||
|
||
* no file extension → `.cts`, `.mts`, `.js`, `.ts`, `.d.cts`, `.d.mts`, or `.d.ts` | ||
* `.cjs` → `.cts`, `.mjs` → `.mts`, `.js` → `.ts` | ||
* `.js` → `.d.cts`, `.d.mts`, or `.d.ts` | ||
* [Package.json subimports](https://nodejs.org/api/packages.html#subpath-imports) | ||
* [tsconfig paths](https://www.typescriptlang.org/tsconfig/#paths) (via [`@nodejs-loaders/alias`](https://github.com/JakobJingleheimer/nodejs-loaders/blob/main/packages/alias?tab=readme-ov-file)) | ||
* In order to subsequently run code via node, you will need to add this (or another) loader to your own project. Or, switch to [subimports](https://nodejs.org/api/packages.html#subpath-imports). | ||
* Commonjs-like directory specifiers | ||
|
||
Before: | ||
|
||
```ts | ||
import { URL } from 'node:url'; | ||
|
||
import { bar } from '@dep/bar'; | ||
import { foo } from 'foo'; | ||
|
||
import { Bird } from './Bird'; // a directory | ||
import { Cat } from './Cat.ts'; | ||
import { Dog } from '…/Dog/index.mjs'; // tsconfig paths | ||
import { baseUrl } from '#config.js'; // package.json imports | ||
|
||
export { Zed } from './zed'; | ||
|
||
export const makeLink = (path: URL) => (new URL(path, baseUrl)).href; | ||
|
||
const nil = await import('./nil.js'); | ||
|
||
const bird = new Bird('Tweety'); | ||
const cat = new Cat('Milo'); | ||
const dog = new Dog('Otis'); | ||
``` | ||
|
||
After: | ||
|
||
```ts | ||
import { URL } from 'node:url'; | ||
|
||
import { bar } from '@dep/bar'; | ||
import { foo } from 'foo'; | ||
|
||
import { Bird } from './Bird/index.ts'; | ||
import { Cat } from './Cat.ts'; | ||
import { Dog } from '…/Dog/index.mts'; // tsconfig paths | ||
import { baseUrl } from '#config.js'; // package.json imports | ||
|
||
export type { Zed } from './zed.d.ts'; | ||
|
||
export const makeLink = (path: URL) => (new URL(path, baseUrl)).href; | ||
|
||
const nil = await import('./nil.ts'); | ||
|
||
const bird = new Bird('Tweety'); | ||
const cat = new Cat('Milo'); | ||
const dog = new Dog('Otis'); | ||
``` |
Oops, something went wrong.