-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add "publish" GHA #11
base: main
Are you sure you want to change the base?
Conversation
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:40
- The node-version value 'node' is ambiguous. It should be a specific version number or range, like '14' or '14.x'.
node-version: node
This comment was marked as resolved.
This comment was marked as resolved.
fe81da4
to
e28a8b4
Compare
e28a8b4
to
31526c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There are a few issues blocking this:
|
This turned out to be a red-herring: it was actually throwing when it got to |
const opts: BuildOptions = { | ||
format: 'esm', | ||
}; | ||
|
||
export default opts; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const opts: BuildOptions = { | |
format: 'esm', | |
}; | |
export default opts; | |
export default { | |
format: 'esm', | |
} as BuildOptions; |
Todo: