Fix empty delimiter strip issue

nosir · Jul 31, 2016 · 09aaaee · 09aaaee
1 parent ef7a2c4
commit 09aaaee
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 11 deletions.
diff --git a/bower.json b/bower.json
@@ -8,7 +8,7 @@
     "form",
     "input"
   ],
-  "version": "0.6.0",
+  "version": "0.6.1",
   "author": {
     "name": "Max Huang",
     "email": "[email protected]",

diff --git a/dist/cleave-react.js b/dist/cleave-react.js
@@ -753,7 +753,9 @@ return /******/ (function(modules) { // webpackBootstrap
 	    stripDelimiters: function stripDelimiters(value, delimiter, delimiters) {
 	        // single delimiter
 	        if (delimiters.length === 0) {
-	            return value.replace(new RegExp('\\' + delimiter, 'g'), '');
+	            var delimiterRE = delimiter ? new RegExp('\\' + delimiter, 'g') : '';
+
+	            return value.replace(delimiterRE, '');
 	        }
 
 	        // multiple delimiters

diff --git a/dist/cleave-react.min.js b/dist/cleave-react.min.js
diff --git a/dist/cleave.js b/dist/cleave.js
@@ -123,7 +123,7 @@ Cleave.prototype = {
         // case 2: last character is not delimiter which is:
         // 12|34* -> hit backspace -> 1|34*
         // note: no need to apply this for numeral mode
-        if (!pps.numeral && pps.backspace && !Cleave.Util.isDelimiter(value.slice(-1), pps.delimiter, pps.delimiters)) {
+        if (!pps.numeral && pps.backspace && !Util.isDelimiter(value.slice(-1), pps.delimiter, pps.delimiters)) {
             value = Util.headStr(value, value.length - 1);
         }
 
@@ -305,7 +305,9 @@ var Util = {
     stripDelimiters: function (value, delimiter, delimiters) {
         // single delimiter
         if (delimiters.length === 0) {
-            return value.replace(new RegExp('\\' + delimiter, 'g'), '');
+            var delimiterRE = delimiter ? new RegExp('\\' + delimiter, 'g') : '';
+
+            return value.replace(delimiterRE, '');
         }
 
         // multiple delimiters

diff --git a/dist/cleave.min.js b/dist/cleave.min.js
diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
     "form",
     "input"
   ],
-  "version": "0.6.0",
+  "version": "0.6.1",
   "author": {
     "name": "Max Huang",
     "url": "http://github.com/nosir",

diff --git a/src/Cleave.js b/src/Cleave.js
@@ -121,7 +121,7 @@ Cleave.prototype = {
         // case 2: last character is not delimiter which is:
         // 12|34* -> hit backspace -> 1|34*
         // note: no need to apply this for numeral mode
-        if (!pps.numeral && pps.backspace && !Cleave.Util.isDelimiter(value.slice(-1), pps.delimiter, pps.delimiters)) {
+        if (!pps.numeral && pps.backspace && !Util.isDelimiter(value.slice(-1), pps.delimiter, pps.delimiters)) {
             value = Util.headStr(value, value.length - 1);
         }
 

diff --git a/src/utils/Util.js b/src/utils/Util.js
@@ -25,7 +25,9 @@ var Util = {
     stripDelimiters: function (value, delimiter, delimiters) {
         // single delimiter
         if (delimiters.length === 0) {
-            return value.replace(new RegExp('\\' + delimiter, 'g'), '');
+            var delimiterRE = delimiter ? new RegExp('\\' + delimiter, 'g') : '';
+
+            return value.replace(delimiterRE, '');
         }
 
         // multiple delimiters