Prevent cascading updates in componentDidUpdate (#570)

nosir · Mar 4, 2020 · b9a9e17 · b9a9e17
1 parent 69222e3
commit b9a9e17
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Cleave.react.js b/src/Cleave.react.js
@@ -16,15 +16,14 @@ var cleaveReactClass = CreateReactClass({
         this.init();
     },
 
-    componentDidUpdate: function () {
+    componentDidUpdate: function (prevProps) {
         var owner = this,
             phoneRegionCode = (owner.props.options || {}).phoneRegionCode,
             newValue = owner.props.value,
             pps = owner.properties;
 
         owner.updateRegisteredEvents(owner.props);
-        if (newValue !== undefined && newValue !== null) {
-
+        if (prevProps.value !== newValue && newValue !== undefined && newValue !== null) {
             newValue = newValue.toString();
 
             if (newValue !== owner.properties.result) {
@@ -34,7 +33,8 @@ var cleaveReactClass = CreateReactClass({
         }
 
         // update phone region code
-        if (phoneRegionCode && phoneRegionCode !== owner.properties.phoneRegionCode) {
+        const prevPhoneRegionCode = (prevProps.options || {}).phoneRegionCode;
+        if (prevPhoneRegionCode !== phoneRegionCode && phoneRegionCode && phoneRegionCode !== owner.properties.phoneRegionCode) {
             owner.properties.phoneRegionCode = phoneRegionCode;
             owner.initPhoneFormatter();
             owner.onInput(owner.properties.result);