Skip to content

Commit

Permalink
fix(storybook): fix externalDependencies undefined (#28641)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
xiongemi authored and jaysoo committed Oct 25, 2024
1 parent 1808ef8 commit 5a45aa0
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions packages/storybook/src/plugins/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ function buildTarget(
isStorybookTestRunnerInstalled()
? '@storybook/test-runner'
: undefined,
],
].filter(Boolean),
},
],
};
Expand All @@ -210,7 +210,7 @@ function buildTarget(
isStorybookTestRunnerInstalled()
? '@storybook/test-runner'
: undefined,
],
].filter(Boolean),
},
],
};
Expand Down Expand Up @@ -248,12 +248,7 @@ function testTarget(projectRoot: string) {
options: { cwd: projectRoot },
inputs: [
{
externalDependencies: [
'storybook',
isStorybookTestRunnerInstalled()
? '@storybook/test-runner'
: undefined,
],
externalDependencies: ['storybook', '@storybook/test-runner'],
},
],
};
Expand Down

0 comments on commit 5a45aa0

Please sign in to comment.