feat(core): expand meaning of plugins array to allow installing non-runtime plugins and inter-opt with installations property #22108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit c831d97.
☁️ Nx Cloud last updated this comment at |
AgentEnder
force-pushed
the
feat/allow-passing-version-in-plugins-array
branch
from
87174d3 to
6abd9ed
Compare
AgentEnder
force-pushed
the
feat/allow-passing-version-in-plugins-array
branch
from
a4da69e to
238bd08
Compare
AgentEnder
force-pushed
the
feat/allow-passing-version-in-plugins-array
branch
from
238bd08 to
669083d
Compare
AgentEnder
force-pushed
the
feat/allow-passing-version-in-plugins-array
branch
from
669083d to
3d6678a
Compare
AgentEnder
force-pushed
the
feat/allow-passing-version-in-plugins-array
branch
from
3d6678a to
bf8527e
Compare
AgentEnder
force-pushed
the
feat/allow-passing-version-in-plugins-array
branch
from
bf8527e to
c474c2c
Compare
AgentEnder
force-pushed
the
feat/allow-passing-version-in-plugins-array
branch
from
c474c2c to
77c872c
Compare
…untime plugins and interopt with installations property
AgentEnder
force-pushed
the
feat/allow-passing-version-in-plugins-array
branch
from
77c872c to
c831d97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Folks using the nx wrapper (nxw.js in .nx) install plugins in nx.json[installation][plugins].
This is a bit weird since there is also nx.json[plugins]
Expected Behavior
You can specify plugins in the top level plugins array.
This PR also adds a field called "runtime" that can be set to false to tell Nx that a plugin worker doesn't need to be spawned for a listed plugin.
This PR fixes up:
nx migratesupport for plugins array contained versionsnx add, to add plugins to the plugins array by defaultRelated Issue(s)
Fixes #