-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add option ciGroupName
to allow customizing the name of…
#29365
Open
tinesoft
wants to merge
1
commit into
nrwl:master
Choose a base branch
from
tinesoft:feat/jest-atomizer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+740
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit a778f68.
☁️ Nx Cloud last updated this comment at |
4 tasks
tinesoft
force-pushed
the
feat/jest-atomizer
branch
from
December 17, 2024 08:04
ab0b5f3
to
367b046
Compare
Your CI Pipeline Execution ↗ for commit 86384d3 is in progress ⏳
☁️ Nx Cloud last updated this comment at |
tinesoft
force-pushed
the
feat/jest-atomizer
branch
from
December 17, 2024 20:34
367b046
to
df1d130
Compare
tinesoft
force-pushed
the
feat/jest-atomizer
branch
from
December 18, 2024 08:57
df1d130
to
86384d3
Compare
tinesoft
force-pushed
the
feat/jest-atomizer
branch
from
December 19, 2024 09:56
86384d3
to
b501652
Compare
tinesoft
force-pushed
the
feat/jest-atomizer
branch
from
December 23, 2024 08:24
b501652
to
73d9507
Compare
… `Jest` atomized taks group on CI Closes nrwl#28066
tinesoft
force-pushed
the
feat/jest-atomizer
branch
from
December 30, 2024 11:54
73d9507
to
a778f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Jest
atomized taks group on CICurrent Behavior
When using Atomizer on Jest for unit tests (via the
"ciTargetName": "test-ci"
), the atomized tasks will be grouped under the misleading name "E2E (CI)".Worst, if Atomizer is enabled for both unit and e2e tests, it will result on E2E atomized tasks being overwritten by the one from unit tests... when run on Nx Cloud.
Expected Behavior
Allow customizing the name of the atomized tasks group. The group name can be derived from the
ciTargetName
, when not explicitly provided.Related Issue(s)
Fixes #28066