Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): update turborepo migration guide #29522

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

th1m0
Copy link
Contributor

@th1m0 th1m0 commented Jan 6, 2025

I came across the TurboRepo migration guide and noticed some outdated TurboRepo configurations.

I’ve updated the migration guide for TurboRepo. However, the documentation still lacks some global configurations:

I'm not entirely sure if these should be included in the migration guide or what their equivalent would be in nx, as I'm not yet very familiar with nx.

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 16, 2025 6:12pm

@th1m0 th1m0 changed the title Docs/fix-turborepo-migration-guide docs(migration): update turborepo migration guide Jan 6, 2025
Copy link

nx-cloud bot commented Jan 6, 2025

View your CI Pipeline Execution ↗ for commit 8db7695.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 3m 7s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 55s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=8a6e4... ✅ Succeeded 21s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 20s View ↗
nx documentation --no-dte ✅ Succeeded 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-16 18:16:11 UTC

@th1m0 th1m0 marked this pull request as ready for review January 6, 2025 15:27
@th1m0 th1m0 requested a review from a team as a code owner January 6, 2025 15:27
@th1m0 th1m0 requested a review from jaysoo January 6, 2025 15:27
@JamesHenry JamesHenry requested review from isaacplmann and removed request for jaysoo January 14, 2025 15:43
@isaacplmann isaacplmann self-assigned this Jan 15, 2025
@isaacplmann
Copy link
Collaborator

Thanks for the contribution! I'll get this into a mergeable state later today and then follow up with another PR that will address the configuration settings that you mentioned.

docs: rename pipeline to tasks

docs: changed some variable names and removed some variables

docs: add `interactive` as a task configuration

fix: fmt
@isaacplmann isaacplmann merged commit dd9db36 into nrwl:master Jan 16, 2025
6 checks passed
bcabanes pushed a commit that referenced this pull request Jan 16, 2025
I came across the TurboRepo migration guide and noticed some outdated
TurboRepo configurations.

I’ve updated the migration guide for TurboRepo. However, the
documentation still lacks some global configurations:

- [ui](https://turbo.build/repo/docs/reference/configuration#ui)
- cacheDir
- [deamon](https://turbo.build/repo/docs/reference/configuration#daemon)
-
[envMode](https://turbo.build/repo/docs/reference/configuration#envmode)
-
[remoteCaching](https://turbo.build/repo/docs/core-concepts/remote-caching)

I'm not entirely sure if these should be included in the migration guide
or what their equivalent would be in nx, as I'm not yet very familiar
with nx.
@isaacplmann
Copy link
Collaborator

#29656

FrozenPandaz pushed a commit that referenced this pull request Jan 17, 2025
I came across the TurboRepo migration guide and noticed some outdated
TurboRepo configurations.

I’ve updated the migration guide for TurboRepo. However, the
documentation still lacks some global configurations:

- [ui](https://turbo.build/repo/docs/reference/configuration#ui)
- cacheDir
- [deamon](https://turbo.build/repo/docs/reference/configuration#daemon)
-
[envMode](https://turbo.build/repo/docs/reference/configuration#envmode)
-
[remoteCaching](https://turbo.build/repo/docs/core-concepts/remote-caching)

I'm not entirely sure if these should be included in the migration guide
or what their equivalent would be in nx, as I'm not yet very familiar
with nx.

(cherry picked from commit dd9db36)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants