-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add ESM support for Eslint config file #29613
Open
ndcunningham
wants to merge
5
commits into
master
Choose a base branch
from
feat/eslint-esm-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,289
−1,269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit db46958.
☁️ Nx Cloud last updated this comment at |
ndcunningham
force-pushed
the
feat/eslint-esm-support
branch
2 times, most recently
from
January 15, 2025 18:42
fb3c46d
to
127a1d3
Compare
ndcunningham
force-pushed
the
feat/eslint-esm-support
branch
from
January 15, 2025 23:35
127a1d3
to
c6bb641
Compare
ndcunningham
force-pushed
the
feat/eslint-esm-support
branch
from
January 16, 2025 00:07
c6bb641
to
7c42373
Compare
ndcunningham
force-pushed
the
feat/eslint-esm-support
branch
3 times, most recently
from
January 16, 2025 14:26
2a78ad4
to
982ffb5
Compare
ndcunningham
force-pushed
the
feat/eslint-esm-support
branch
from
January 16, 2025 15:12
982ffb5
to
5b049ce
Compare
ndcunningham
changed the title
feat(core): Add support for ESM config file
feat(core): Add ESM support for Eslint config file
Jan 16, 2025
Coly010
approved these changes
Jan 16, 2025
jaysoo
reviewed
Jan 16, 2025
jaysoo
approved these changes
Jan 16, 2025
ndcunningham
force-pushed
the
feat/eslint-esm-support
branch
2 times, most recently
from
January 17, 2025 01:18
26e015d
to
0c6a6cf
Compare
…flat config generation
ndcunningham
force-pushed
the
feat/eslint-esm-support
branch
from
January 17, 2025 14:03
0c6a6cf
to
de15ea4
Compare
ndcunningham
force-pushed
the
feat/eslint-esm-support
branch
from
January 17, 2025 14:27
de15ea4
to
db46958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to migrate ESLint configuration files from CommonJS (
.cjs
) to ECMAScript modules (.mjs
) as the default.ESLint Configuration Generation Changes
The changes also ensure consistent generated eslint configs based on the base eslint config.
eslint.config.cjs
oreslint.config.js
withmodule.exports
. When you create a library or application it will generate an accompanying config at path{projectRoot}/eslint.config.cjs
of the same format.eslint.config.mjs
oreslint.config.mjs
withexport default
. When you create a library or application it will generate an accompanying config at path{projectRoot}/eslint.config.mjs
.eslint.config.mjs