Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): generate module and moduleResolution in base tsconfig based on cnw preset #29633

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jan 15, 2025

Current Behavior

Creating a new workspace using the TS solution setup always generates a tsconfig.base.json with module: nodenext and moduleResolution: nodenext.

Expected Behavior

Creating a new workspace using the TS solution setup should generate a tsconfig.base.json with module: nodenext/moduleResolution: nodenext for Node stacks and module: esnext/moduleResolution: bundler for Web stacks (React, Vue).

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jan 15, 2025
@leosvelperez leosvelperez requested review from a team and Coly010 as code owners January 15, 2025 16:38
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 4:39pm

@leosvelperez leosvelperez requested a review from jaysoo January 15, 2025 16:38
Copy link

nx-cloud bot commented Jan 15, 2025

View your CI Pipeline Execution ↗ for commit 666816e.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 40m 50s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 56s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=32a2c... ✅ Succeeded 22s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 19s View ↗
nx documentation --no-dte ✅ Succeeded 40s View ↗
nx affected -t e2e-macos-local --parallel=1 --b... ✅ Succeeded 21m 59s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-15 17:23:57 UTC

@jaysoo jaysoo merged commit a127177 into master Jan 15, 2025
6 checks passed
@jaysoo jaysoo deleted the js/cnw-module-resolution branch January 15, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants