fix(js): sort package.json fields by idiomatic order #29635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 1edb6d2.
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Jan 15, 2025
jaysoo
force-pushed
the
fix/sort-package-json
branch
from
5a40ef3 to
937aeda
Compare
jaysoo
force-pushed
the
fix/sort-package-json
branch
from
937aeda to
1edb6d2
Compare
jaysoo
force-pushed
the
fix/sort-package-json
branch
from
46e8d2e to
1edb6d2
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 17, 2025
This PR updates our app/lib generators such that `package.json` files
generated have fields in idiomatic order.
e.g.
```json
{
"name": "...",
"version": "...",
"private": true,
"type": "module",
"main": "...",
...
"dependencies": { ... }
}
```
The import fields such as name, version, private, and type are at the
top. Dep fields that could be noisy are at the bottom.
## Current Behavior
<!-- This is the behavior we have today -->
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes #
(cherry picked from commit cc441a6)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our app/lib generators such that
package.jsonfiles generated have fields in idiomatic order.e.g.
{ "name": "...", "version": "...", "private": true, "type": "module", "main": "...", ... "dependencies": { ... } }The import fields such as name, version, private, and type are at the top. Dep fields that could be noisy are at the bottom.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #