fix(js): do not generate package.json file for non-buildable js libraries in non-ts solution setup #29646
+30
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 69a239b.
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Jan 16, 2025
…ries in non-ts solution setup
leosvelperez
force-pushed
the
js/fix-package-json-generation
branch
from
fbb9b8a to
69a239b
Compare
Coly010
approved these changes
Jan 16, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 17, 2025
…ries in non-ts solution setup (#29646) ## Current Behavior When generating a non-buildable js library in a workspace using the integrated setup, a `package.json` file is generated. ## Expected Behavior When generating a non-buildable js library in a workspace using the integrated setup, a `package.json` file should not be generated. ## Related Issue(s) Fixes # (cherry picked from commit ad96cc1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When generating a non-buildable js library in a workspace using the integrated setup, a
package.jsonfile is generated.Expected Behavior
When generating a non-buildable js library in a workspace using the integrated setup, a
package.jsonfile should not be generated.Related Issue(s)
Fixes #