fix(js): ignore bundler config files correctly in eslint config when using vitest in js library generator #29649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using vitest in js library generator
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 40d9f53.
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Jan 16, 2025
jaysoo
reviewed
Jan 16, 2025
| '{projectRoot}/vite.config.{js,ts,mjs,mts}' | ||
| ); | ||
| o.rules['@nx/dependency-checks'] = [ruleSeverity, ruleOptions]; | ||
| const ignoredFiles = new Set(ruleOptions.ignoredFiles ?? []); |
There was a problem hiding this comment.
Technically you could remove the else if from 477 and achieve the same result.
if (options.bundler === "vite" || options.unitTestRunner === 'vitest') {
ignoredFiles.add("{projectRoot}/vite.config.{js,ts,mjs,mts}");
}
if (options.bundler === "rollup") {
ignoredFiles.add("{projectRoot}/rollup.config.{js,ts,mjs,mts,cjs,cts}");
} else if (options.bundler === "esbuild") {
ignoredFiles.add("{projectRoot}/esbuild.config.{js,ts,mjs,mts}");
}There was a problem hiding this comment.
It works, but I don't think it reads as well because you already check for bundler === vite first, so, there's no way it can be bundler === rollup if that was the case. Checking for bundlers and unit test runners separately feels better to me.
jaysoo
approved these changes
Jan 16, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 17, 2025
…using vitest in js library generator (#29649) ## Current Behavior Generating a js library with esbuild or rollup as bundlers and vitest as the unit test runner, results in an eslint configuration where the bundler config file is not ignored from the `@nx/dependency-checks` rule. ## Expected Behavior Generating a js library with esbuild or rollup as bundlers and vitest as the unit test runner, should result in an eslint configuration where the bundler config file is ignored from the `@nx/dependency-checks` rule. ## Related Issue(s) Fixes # (cherry picked from commit 8a6e44b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Generating a js library with esbuild or rollup as bundlers and vitest as the unit test runner, results in an eslint configuration where the bundler config file is not ignored from the
@nx/dependency-checksrule.Expected Behavior
Generating a js library with esbuild or rollup as bundlers and vitest as the unit test runner, should result in an eslint configuration where the bundler config file is ignored from the
@nx/dependency-checksrule.Related Issue(s)
Fixes #