improve test

nuclio · Feb 7, 2024 · df4cd88 · df4cd88
1 parent ad5ebc4
commit df4cd88
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 2 deletions.
diff --git a/nuclio/triggers.py b/nuclio/triggers.py
@@ -245,7 +245,7 @@ def __init__(
         **deprecated_kwargs,
     ):
         # TODO: delete deprecated arguments in 0.10.0
-        deprecation_warning_template = "Deprecated argument '{old_arg_name}' will be removed in 0.10.0 version. " \
+        deprecation_warning_template = "Using deprecated argument '{old_arg_name}' will be removed in 0.10.0 version." \
                                        "Please use '{new_arg_name}' instead."
 
         if "seekTo" in deprecated_kwargs:

diff --git a/tests/test_triggers.py b/tests/test_triggers.py
@@ -101,12 +101,47 @@ def test_http_trigger_extra():
     assert http_trigger._struct["attributes"]["y"] == "456"
 
 
-def test_renamed_deprecated_values():
+def test_renamed_deprecated_values_old_names():
     trigger = V3IOStreamTrigger(seekTo="test",
+                                access_key="abc",
+                                maxWorkers=5,
+                                workerAllocationMode="static",
+                                consumerGroup="cg1",
+                                readBatchSize=128,
+                                sessionTimeout="11s",
+                                sequenceNumCommitInterval="2s",
+                                heartbeatInterval="5s",
+                                pollingIntervalMS=100,
+                                )
+    assert trigger._struct["attributes"]["seekTo"] == "test"
+    assert trigger._struct["attributes"]["workerAllocationMode"] == "static"
+    assert trigger._struct["attributes"]["consumerGroup"] == "cg1"
+    assert trigger._struct["attributes"]["readBatchSize"] == 128
+    assert trigger._struct["attributes"]["sessionTimeout"] == "11s"
+    assert trigger._struct["attributes"]["sequenceNumberCommitInterval"] == "2s"
+    assert trigger._struct["attributes"]["heartbeatInterval"] == "5s"
+    assert trigger._struct["attributes"]["pollingIntervalMs"] == 100
+    assert trigger._struct["maxWorkers"] == 5
+
+
+def test_renamed_deprecated_values_new_names():
+    trigger = V3IOStreamTrigger(seek_to="test",
                                 access_key="abc",
                                 maxWorkers=5,
                                 worker_allocation_mode="static",
+                                consumer_group="cg1",
+                                read_batch_size=128,
+                                session_timeout="11s",
+                                sequence_num_commit_interval="2s",
+                                heartbeat_interval="5s",
+                                polling_interval_ms=100,
                                 )
     assert trigger._struct["attributes"]["seekTo"] == "test"
     assert trigger._struct["attributes"]["workerAllocationMode"] == "static"
+    assert trigger._struct["attributes"]["consumerGroup"] == "cg1"
+    assert trigger._struct["attributes"]["readBatchSize"] == 128
+    assert trigger._struct["attributes"]["sessionTimeout"] == "11s"
+    assert trigger._struct["attributes"]["sequenceNumberCommitInterval"] == "2s"
+    assert trigger._struct["attributes"]["heartbeatInterval"] == "5s"
+    assert trigger._struct["attributes"]["pollingIntervalMs"] == 100
     assert trigger._struct["maxWorkers"] == 5