Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete dots from the file name #179

Merged
merged 2 commits into from
May 9, 2024
Merged

Delete dots from the file name #179

merged 2 commits into from
May 9, 2024

Conversation

rokatyy
Copy link
Contributor

@rokatyy rokatyy commented May 8, 2024 •
edited
Loading

Jira - https://iguazio.atlassian.net/browse/ML-2223

This PR addresses the issue of IPython Notebook (.ipynb) names containing dots.

@rokatyy rokatyy marked this pull request as ready for review May 8, 2024 14:47
TomerShor
TomerShor approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@TomerShor TomerShor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I would check if there are other places in the code that we could use this normalize_name function to avoid errors.

@TomerShor TomerShor merged commit 001f222 into nuclio:development May 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomerShor TomerShor TomerShor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokatyy @TomerShor