Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator test fixes for Python 3.12 version upgrade #109

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Simulator test fixes for Python 3.12 version upgrade #109

merged 6 commits into from
Dec 11, 2023

Conversation

kc611
Copy link
Contributor

@kc611 kc611 commented Nov 23, 2023

As titled,

This PR adds a fixes for the simulator tests that fail during shift to Python 3.12.

esc
esc requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review about using PYVERSION.

numba_rvsdg/tests/simulator.py Outdated Show resolved Hide resolved
numba_rvsdg/tests/simulator.py Outdated Show resolved Hide resolved
@esc
Copy link
Member

esc commented Nov 23, 2023

Fix for the RTD build failure is here: #110

@esc
Copy link
Member

esc commented Nov 23, 2023

Fix for the RTD build failure is here: #110

Seems like the fix is good. @kc611 would suggest you review and merge that and then rebase this PR onto resulting main. Sound like a plan?

esc
esc requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change before merging. Looking good.

numba_rvsdg/tests/simulator.py Outdated Show resolved Hide resolved
esc
esc requested changes Dec 9, 2023
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require an additional else clause.

numba_rvsdg/tests/simulator.py Show resolved Hide resolved
esc
esc approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esc esc merged commit 1cababd into numba:main Dec 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esc esc esc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kc611 @esc