[T3A3][W13-A3]Marianne Quek #1082
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K1ang
reviewed
Mar 5, 2017
There was a problem hiding this comment.
@marianne121 Some comments added. Please close the PR after reading comments.
| @@ -38,22 +53,22 @@ public static boolean isValidAddress(String test) { | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| return value; | |||
| return block.getBlock() + ", " + street.getStreet() + ", " + unit.getUnit() + ", " + postalCode.getPostalCode(); | |||
| } | |||
| @@ -0,0 +1,13 @@ | |||
| package seedu.addressbook.data.person; | |||
|
|
|||
| public class Block { | |||
There was a problem hiding this comment.
Remember to include header comments for these classes to tell developments how to use these classes.
| public String getFeedbackToUser() { | ||
| return feedbackToUser; | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this for T3A2? Try not to include multiple different activities in a PR unless stated.
| list | ||
|
|
||
| # should not allow adding duplicate persons | ||
| add Esther Potato p/555555 e/[email protected] pa/555, epsilon street t/tubers t/starchy | ||
| add Esther Potato p/555555 e/[email protected] pa/123, 555 epsilon street, #123, 123456 t/tubers t/starchy | ||
|
|
|
|
||
| private final UniqueTagList tags; | ||
| private static int nextSeqNo = 0; |
There was a problem hiding this comment.
Try to cherry pick and submit if you have multiple activities done. Else you can do them in separate branches to avoid sending in multiple activities in a single PR.
| || (other instanceof Address // instanceof handles nulls | ||
| && this.value.equals(((Address) other).value)); // state check | ||
| || (other instanceof Address // instance of handles nulls | ||
| && this.toString().equals(((Address) other).toString())); // state check | ||
| } |
There was a problem hiding this comment.
How about using each smaller classes for their specific comparisons?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.