Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to latest @nuxt/module-builder #712

Merged
merged 4 commits into from
Aug 24, 2024
Merged

build: update to latest @nuxt/module-builder #712

merged 4 commits into from
Aug 24, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Not sure if there was a reason this was pinned, but this updates to the latest module builder to avoid an issue with mismatching declarations + compiled files.

Copy link

cloudflare-workers-and-pages bot commented Aug 23, 2024

Deploying nuxt-devtools with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 5829a21
Status:Β βœ…Β  Deploy successful!
Preview URL: https://c3b90c56.nuxt-devtools.pages.dev
Branch Preview URL: https://chore-builder.nuxt-devtools.pages.dev

View logs

@antfu
Copy link
Member

antfu commented Aug 24, 2024

I think the problem was the .js extension for runtime modules, where we have some files shared between the client and node side, where .mjs is desired.

@antfu
Copy link
Member

antfu commented Aug 24, 2024

Ah, should be good now πŸ‘Œ

@antfu antfu enabled auto-merge (squash) August 24, 2024 16:50
@antfu antfu merged commit b3f386a into main Aug 24, 2024
3 checks passed
@antfu antfu deleted the chore/builder branch August 24, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants