Fix bug in chunked()

nvie · Dec 9, 2019 · 2ef997c · 2ef997c
1 parent 96e13b2
commit 2ef997c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+v1.5.3
+------
+* Fix bug in `chunked()` when input is exactly dividable
+
 v1.5.2
 ------
 * Export `count()` function at the top level 🤦‍♂️

diff --git a/src/__tests__/more-itertools.test.js b/src/__tests__/more-itertools.test.js
@@ -32,6 +32,13 @@ describe('chunked', () => {
             [4, 5],
         ]);
     });
+
+    it('works with exactly chunkable list', () => {
+        expect(Array.from(chunked([1, 2, 3, 4, 5, 6], 3))).toEqual([
+            [1, 2, 3],
+            [4, 5, 6],
+        ]);
+    });
 });
 
 describe('first', () => {

diff --git a/src/more-itertools.js b/src/more-itertools.js
@@ -35,7 +35,10 @@ export function* chunked<T>(iterable: Iterable<T>, size: number): Iterable<Array
         }
     }
 
-    yield chunk;
+    // Yield the remainder, if there is any
+    if (chunk.length > 0) {
+        yield chunk;
+    }
 }
 
 /**