-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow pos="center"
, row=0
, line=0
#227
Conversation
As mentioned here, the tests are currently broken as there is no longer a "nightly" tagged neovim release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you are done we can update the notice date and merge this + the telescope PR
https://github.com/nvim-lua/plenary.nvim/pull/227/checks?check_run_id=3645392127#step:3:12 These stylua changes are probably thanks to the 0.11 release https://github.com/JohnnyMorganz/StyLua/releases/tag/v0.11.0 3 days ago. |
@Conni2461 thanks, I was getting very confused 😅 |
@l-kershaw Oh rad, so this does the same thing as in my PR here nvim-lua/popup.nvim#9!? |
@jesseleite yeh, thanks for writing that PR! |
Heavily based on the implementation from this PR by @jesseleite.
Also, added options to center in only one direction using
0
forrow
/line
.This required shifting the indices of everything else by one, which is a bit annoying, but this is how the implementation in vim works, so 🤷
This does break stuff in telescope, so I will write a PR over there when I get a chance.