Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nesting markup in links #432

Closed
wants to merge 3 commits into from
Closed

Conversation

kristijanhusak
Copy link
Member

Related PR: #431

@kristijanhusak
Copy link
Member Author

@gzagatti can you give this PR a test and see if it fixes the issues? It removes some of the code and should fix nesting of the markup and links, at least from what I saw how Emacs behaves.

@kristijanhusak
Copy link
Member Author

Ok I figured out this breaks all the LateX stuff that you did, so I need to reconsider this.

@kristijanhusak
Copy link
Member Author

I think I covered everything. There are some edge cases where it might not behave exactly as Emacs, but it generally doesn't look like valid markup in there also.

@gzagatti
Copy link
Contributor

The code does not seem to tackle cases like:

This is =a *1  b= and *ab cd* foo

Where =a *1 b= should be verbatim and *ab cd* should be bold. We might need to handle orphans like I did PR #431. I could try to bring that logic to this branch. I will just wait for your feedback on my comments in there.

@kristijanhusak kristijanhusak deleted the fix/markup-nesting branch February 14, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants