Fix get_visual argument order bug #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
force-pushed
the
fix-get-visual
branch
2 times, most recently
from
f6e99fc to
f80248a
Compare
weeman1337
approved these changes
Dec 15, 2023
Ensure that the `start_row`, `start_col`, `end_row`, and `end_col` arguments to `nvim_buf_get_text` are passed in the correct order regardless of the direction of the visual selection. Previously, if the end of the visual selection was before the start, `nvim_buf_get_text` would raise an error saying "start_col must be less than end_col".
weeman1337
force-pushed
the
fix-get-visual
branch
from
f80248a to
2371c42
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the
start_row,start_col,end_row, andend_colarguments tonvim_buf_get_textare passed in the correct order regardless of the direction of the visual selection. Previously, if the end of the visual selection was before the start,nvim_buf_get_textwould raise an error saying "start_col must be less than end_col".Fixes #63